-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitbucket pipeline upload fail when git it not available #1521
Comments
Hi @kYem , You found the bug I was going to point you to. Codecov can't use the short SHA because only Bitbucket knows what that expends to, meaning we can't get data regarding the commit from the API. If you add the workaround from that Jira ticket though, I believe it works. Have you had a chance to try that? |
Well the solution is the same, enable I think the main thing is that So the case of passing valid |
Describe the bug
The issue is that _getSha function still calls runExternalProgram, even when
args.sha
is passed even if the result is discardedTo Reproduce
Steps to reproduce the behavior:
image: node:18-buster-slim
[2024-04-08T14:50:48.136Z] ['info'] Using manual override from args. [2024-04-08T14:50:48.137Z] ['info'] Detected Bitbucket as the CI provider. [2024-04-08T14:50:48.137Z] ['verbose'] -> Using the following env variables: [2024-04-08T14:50:48.137Z] ['verbose'] CI: true [2024-04-08T14:50:48.137Z] ['verbose'] BITBUCKET_BUILD_NUMBER: 13944 [2024-04-08T14:50:48.142Z] ['error'] Error detecting repos setting using git: Error: Error running external program: Error: spawnSync git ENOENT [2024-04-08T14:50:48.143Z] ['verbose'] Using the following upload parameters: [2024-04-08T14:50:48.143Z] ['verbose'] commit [2024-04-08T14:50:48.143Z] ['verbose'] name [2024-04-08T14:50:48.143Z] ['verbose'] tag [2024-04-08T14:50:48.143Z] ['verbose'] flags [2024-04-08T14:50:48.143Z] ['verbose'] parent [2024-04-08T14:50:48.144Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=uploader-0.7.2&token=*******&commit=d9d3d2a783ff&name=&tag=&flags=&parent= [2024-04-08T14:50:48.144Z] ['verbose'] Passed token was 36 characters long [2024-04-08T14:50:48.144Z] ['verbose'] https://codecov.io/upload/v4?package=uploader-0.7.2&commit=d9d3d2a783ff&name=&tag=&flags=&parent= Content-Type: 'text/plain' Content-Encoding: 'gzip' X-Reduced-Redundancy: 'false' [2024-04-08T14:50:48.293Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io/: Error: There was an error fetching the storage URL during POST: 400 - Invalid request parameters [2024-04-08T14:50:48.293Z] ['verbose'] The error stack is: Error: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 400 - Invalid request parameters at main (/snapshot/repo/dist/src/index.js) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) [2024-04-08T14:50:48.294Z] ['verbose'] End of uploader: 863 milliseconds [2024-04-08T14:50:48.294Z] ['info'] Codecov will exit with status code 0. If you are expecting a non-zero exit code, please pass in the `-Z` flag
Expected behavior
It should accept the passed in commit, or display actual error that commit format is not valid. (if full sha is required?)
These seems to be also a weird problem where Bitbucket on first runs returns short sha (12 characters) on follow up it returns full sha (40 characters) that actually works. See second run screenshot.
Screenshots
First run:
Second run:
Additional context
If Codecov can only work full sha it return error, saying that sha passed in is not valid. Ideally Codecov should accept both?
Seems to be different behaviour on pull-request run vs manual run...
https://jira.atlassian.com/browse/BCLOUD-19393
The text was updated successfully, but these errors were encountered: