Skip to content

Commit 6e881ba

Browse files
authored
fix: position of favicon to be centered for better UX in datatables (#186)
1 parent 0f91b5d commit 6e881ba

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

app/assets/stylesheets/manage.sass

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@ $grey-med: #999
6969
// display: inline-block
7070
// &:hover
7171
// color: darken($grey-light, 5%)
72+
.center
73+
text-align: center
7274

7375
.land
7476
fill: #dadada

app/datatables/checkin_datatable.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def view_columns
1414
def about(record)
1515
output = ""
1616
output += [record.first_name, record.last_name].join(" ") + " "
17-
output += '<span class="badge badge-warning"><i class="fa fa-exclamation-triangle icon-space-r"></i>Minor</span>' if record.minor?
17+
output += '<span class="badge badge-warning"><i class="fa fa-exclamation-triangle"></i>Minor</span>' if record.minor?
1818
output += "<br /><small>" + record.school.name + "</small>"
1919
output.html_safe
2020
end

app/datatables/questionnaire_datatable.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ def view_columns
2626

2727
def note(record)
2828
output = ""
29-
output += '<i class="fa fa-exclamation-triangle icon-space-r"></i> <small>Minor</small>' if record.minor?
30-
output += '<i class="fa fa-bus icon-space-r" title="Riding bus"></i>' if record.bus_list_id?
29+
output += '<i class="fa fa-exclamation-triangle"></i> <small>Minor</small>' if record.minor?
30+
output += '<i class="fa fa-bus" title="Riding bus"></i>' if record.bus_list_id?
3131
output += "<small>Captain</small>" if record.is_bus_captain?
3232
output = '<div class="center">' + output + "</div>" if output.present?
3333
output.html_safe

0 commit comments

Comments
 (0)