-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise expected VALUE for StudentFacingError(VALUE) #58762
Comments
E.g. if we were to throw |
snickell
changed the title
Raise expected VALUE for StudentError(VALUE)
Raise expected VALUE for StudentFacingError(VALUE)
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To get appropriate UX errors from Data Browser forms, we need to raise hardcoded VALUE for the StudentError.
Here's some from DataOverView.jsx for clicking the create table button: https://github.com/code-dot-org/code-dot-org/blob/84d65fa95b143fc2852b9bc53955d1d505fea094/apps/src/storage/dataBrowser/DataOverview.jsx/#L39-L42
We can be sure the corresponding
raise StudentError(VALUE)
use one of these, like:TABLE_NAME_INVALID
.Another source of these errors would be the enum itselfl (https://github.com/code-dot-org/code-dot-org/blob/19368167d875b535d69e6dddcf0b7f3f11c2a79b/apps/src/storage/constants.js/#L5-L15):
The text was updated successfully, but these errors were encountered: