Skip to content

Async load zxcvbn.js to use with ember-cli-password-strength #1662

Open
@begedin

Description

@begedin

Problem

ember-cli-password-strength, since 2.0.0, has support for asynchronous loading of the zxcvbn.js library.

Since the library is 400k gzipped, it would make sense for us to make use of this.

However, the addon does not provide a framework to actually include the library as part of the project. Instead, it assumes, if aync mode is on, that the library is locaded at ${config.rootUrl}/zxcvbn.js

We need to find a way to deal with this and switch to async mode.

Subtasks

  • Turn on async mode for the addon as per instructions, by modifying the app's ember-cli-build.js and adding
let app = new EmberAddon(defaults, {
  'ember-cli-password-strength': {
    bundleZxcvbn: false
  }
});
  • Provide the library, either at the expected path, or, more likely at our own path, by providing custom async loading facilities, similar to what we do with ember-stripe-elements

https://github.com/code-corps/ember-stripe-elements/blob/master/addon/utils/load-script.js

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions