Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will the coverage upload be skipped only if --skip or -s is passed in? #500

Open
valeriupredoi opened this issue Apr 3, 2024 · 3 comments

Comments

@valeriupredoi
Copy link

valeriupredoi commented Apr 3, 2024

Hi folks, quick question please (sorry I got rid of the Issue template - too much faff for such a simple question): we are using the codacy cov uploader via CircleCI as orb ie:

orbs:
  coverage-reporter: codacy/[email protected]
  codecov: codecov/[email protected]

and noticed that the coverage upload is not skipped if the PR is from a forked repo (so the project API token is missing there), and fails with the obvious "project token missing" - do we have to explicitly have the --skip option turned on to allow for a skip in this case, and avoid a fail? Many thanks in advance! Cheers muchly 🍻

@lolgab
Copy link
Contributor

lolgab commented Apr 3, 2024

Hi @valeriupredoi!
You can use the skip parameter:

orbs:
  coverage-reporter: codacy/[email protected]
  codecov: codecov/[email protected]
  skip: true

@valeriupredoi
Copy link
Author

@lolgab sweet, many thanks, mate! Shall do's, cheers for the pointer 🍺

@valeriupredoi
Copy link
Author

@lolgab my apologies, mate - proves out were were indeed skipping with skip: true (my colleague @bouweandela looked a few lines down the config file, unlike me 🤣 ) - and still, the upload was tried and failed, but only after one merged main in the fork PR-ed branch, otherwise, before that, the upload was indeed skipped on the fork - any ideas? No rush, no major issue here, it's more like a curiosity 🔍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants