wip: only files in git will be considered in the report, file name wi… #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll be according to git file structure ALA-773
pedrobpereira
force-pushed
the
master
branch
from
1a82d23 to
b09d0b0
Compare
pedrobpereira
commented
Dec 15, 2023
|
|
||
| def matchAndReturnName(filename: String, fileNames: Seq[String]): Option[String] = { | ||
|
|
||
| fileNames.find(name => isTheSameFile(filename, name)) |
There was a problem hiding this comment.
To achieve parity with the already implemented mechanisms in our code base (coverage-service, engine) there is still missing a part where we sort by similarity (see code base)
pedrobpereira
commented
Dec 15, 2023
| packageName = pkg \@ "name" | ||
| sourceFile <- pkg \\ "sourcefile" | ||
| filename = s"$packageName/${sourceFile \@ "name"}" | ||
| actualName <- FileNameMatcher |
There was a problem hiding this comment.
This should be moved to a more generic place, after the reports are done, so that we don't have to implement for each parser
|
Will be tackled here #485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ll be according to git file structure ALA-773