Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use BigInt instead of Long in toIntOrMaxValue TS-549 #479

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Nov 7, 2023

Author: @jasonm23

@lolgab lolgab marked this pull request as ready for review November 7, 2023 15:44
Copy link

codacy-production bot commented Nov 7, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-8.59% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3cca982) 686 573 83.53%
Head commit (15df687) 403 (-283) 302 (-271) 74.94% (-8.59%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#479) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

- Add test with big hits number
@lolgab lolgab changed the title fix: Use BigInt instead of Long in toIntOrMaxValue fix: Use BigInt instead of Long in toIntOrMaxValue TS-549 Nov 7, 2023
@lolgab lolgab merged commit 2f2561b into master Nov 8, 2023
2 of 4 checks passed
@lolgab lolgab deleted the big-int-fix branch November 8, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants