Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS-549] use BigInt instead of long in toIntOrMaxValue #473

Merged
merged 1 commit into from
Nov 8, 2023
Merged

[TS-549] use BigInt instead of long in toIntOrMaxValue #473

merged 1 commit into from
Nov 8, 2023

Conversation

jasonm23
Copy link
Contributor

@jasonm23 jasonm23 commented Sep 4, 2023

Should fix #472

@jasonm23 jasonm23 mentioned this pull request Sep 4, 2023
Closed
@lolgab
Copy link
Contributor

lolgab commented Nov 7, 2023

Hi @jasonm23,
Thank you for your contribution. Unfortunately, we are having some problems with the CI pipeline which doesn't run correctly from forks.
I'm going to build on top of your change which currently doesn't compile. Good catch! We didn't expect someone could have so many coverage hits on a line 😄.

@lolgab lolgab merged commit a77e4e5 into codacy:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TS-549] Exception in thread "main" java.lang.NumberFormatException: For input string: "18446744073709551615"
2 participants
@jasonm23 @lolgab