You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
148594: roachprod: add stop option to reset VM failure r=srosenberg,DarrylWong a=herkolategan
When the reset VM failure is injected, we now have the option to stop the
processes before restarting the cluster.
This change also improves process management by starting the processes in the
correct order (System interface first, then tenants).
Epic: None
Release note: None
149119: changefeedccl: fix race advancing frontier in schemafeed r=rharding6373 a=rharding6373
In the schema feed, when in `updateTableHistory`, we check that the current frontier is less than the current time. However, since we release the mutex protecting frontier while validating table descriptors, it's possible for another routine to advance the frontier before the first routine tries to advance it. For example, another routine may call pauseOrResumePolling and pause polling at the same time it advances the frontier.As a consequence, it's possible for the first routine to assert fail due to the current frontier being greater than the current time when it tries to advance it.
This change fixes this race by checking that the frontier is greater than the current time (endTS) again before trying to advance the frontier. If the frontier is less than or equal to the current time, the frontier does not need to be advanced and it returns. It's worth keeping the original check in, since it avoids the need to validate descriptors, and releasing the mutex also prevents the routine from holding it while validating.
Epic: none
Fixes: #148963
Release note (bug fix): Fixes a race condition when advancing a changefeed aggregator's frontier. When hit, the race condition could result in an internal error that would shut down the kvfeed and cause the changefeed to retry.
149262: cockroach-go: bump to latest r=benbardin a=benbardin
Release notes: none
Epic: none
149334: kvserver: embed timestamp to the queued element r=tbg a=pav-kv
Tying the `queued` timestamp to the `rangeID` in the raft scheduler queue makes its scope intuitive, and eliminates the need for an invariant and checks.
Follows up on #147913
Co-authored-by: Herko Lategan <[email protected]>
Co-authored-by: rharding6373 <[email protected]>
Co-authored-by: Ben Bardin <[email protected]>
Co-authored-by: Pavel Kalinnikov <[email protected]>
0 commit comments