Skip to content

Commit 1244350

Browse files
authored
Merge pull request #418 from cncf/feature/#398_test_binary_in_empty_folder
test binary in empty folder
2 parents 3c7da42 + 030af3b commit 1244350

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ jobs:
77
include:
88
- stage: K8s
99
before_script:
10-
- |
1110
# Download and install go
1211
- wget https://dl.google.com/go/go1.13.linux-amd64.tar.gz
1312
- tar -xvf go1.13.linux-amd64.tar.gz

src/tasks/utils/utils.cr

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ require "../constants.cr"
1212
# TODO Move constants out
1313
# TODO put these functions into a module
1414

15+
# TODO: error with proper exit_code when any of these don't exist and ask user to run setup command
1516
CNF_DIR = "cnfs"
1617
CONFIG_FILE = "cnf-conformance.yml"
1718
TOOLS_DIR = "tools"
Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
FROM ubuntu
1+
FROM ubuntu as base
22

3-
ARG VERSION=v3.2.4
4-
ARG FILENAME=helm-${VERSION}-linux-amd64.tar.gz
3+
ARG HELM_VERSION=v3.2.4
4+
ARG FILENAME=helm-${HELM_VERSION}-linux-amd64.tar.gz
55
ARG KUBECTL=v1.18.4
66

7-
RUN apt update && apt install -y wget curl
7+
RUN apt update && apt install -y wget curl git
88

99
RUN curl -L https://get.helm.sh/${FILENAME} | tar zxv -C /tmp
1010
RUN mv /tmp/linux-amd64/helm /usr/local/bin/
@@ -14,4 +14,11 @@ RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/$KUBECTL/
1414
RUN mv ./kubectl /usr/local/bin/kubectl
1515
RUN chmod +x /usr/local/bin/kubectl
1616

17-
WORKDIR /cnf-conformance
17+
WORKDIR /test_workspace
18+
19+
from base as ci_test
20+
# add binary AND ONLY the binary in this container so we can fail if binary is broken without the rest of the source
21+
COPY cnf-conformance .
22+
RUN ./cnf-conformance setup verbose
23+
RUN wget https://raw.githubusercontent.com/cncf/cnf-conformance/master/example-cnfs/coredns/cnf-conformance.yml
24+
RUN ./cnf-conformance ip_addresses cnf-config=./cnf-conformance.yml verbose

tools/curl_install_tester_docker_setup/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ Curl install tester is a docker setup designed to
1313
# in the curl_install_tester_docker_setup folder
1414
# because the dockerfile is there
1515
16-
docker build -t curl_install_tester_docker_setup .
16+
docker build -t curl_install_tester_docker_setup --target base .
1717
18-
docker run --rm -it curl_install_tester_docker_setup
18+
docker run --rm -it curl_install_tester_docker_setup
1919
2020
source <(curl https://raw.githubusercontent.com/cncf/cnf-conformance/master/curl_install.sh)
2121

0 commit comments

Comments
 (0)