Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In v3, Parameters needed for DACCountScan aren't actually passed to the driver #8

Open
ericonr opened this issue Feb 21, 2025 · 0 comments
Labels
lumentum-v3 Issue affects lumentum-v3 branch

Comments

@ericonr
Copy link
Member

ericonr commented Feb 21, 2025

The numModulesX and numModulesY parameters from pimegaDetectorConfig aren't configured in the iocsh command definition, so they aren't passed to the registered function.

extern "C" int pimegaDetectorConfig(
const char *portName, const char *address_module01,
const char *address_module02, const char *address_module03,
const char *address_module04, const char *address_module05,
const char *address_module06, const char *address_module07,
const char *address_module08, const char *address_module09,
const char *address_module10, int port, int maxSizeX, int maxSizeY,
int detectorModel, int maxBuffers, size_t maxMemory, int priority,
int stackSize, int simulate, int backendOn, int log,
unsigned short backend_port, unsigned short vis_frame_port,
int IntAcqResetRDMA, int numModulesX, int numModulesY) {
new pimegaDetector(portName, address_module01, address_module02,
address_module03, address_module04, address_module05,
address_module06, address_module07, address_module08,
address_module09, address_module10, port, maxSizeX,
maxSizeY, detectorModel, maxBuffers, maxMemory, priority,
stackSize, simulate, backendOn, log, backend_port,
vis_frame_port, IntAcqResetRDMA, numModulesX, numModulesY);
return (asynSuccess);
}

static const iocshArg *const pimegaDetectorConfigArgs[] = {
&pimegaDetectorConfigArg0, &pimegaDetectorConfigArg1,
&pimegaDetectorConfigArg2, &pimegaDetectorConfigArg3,
&pimegaDetectorConfigArg4, &pimegaDetectorConfigArg5,
&pimegaDetectorConfigArg6, &pimegaDetectorConfigArg7,
&pimegaDetectorConfigArg8, &pimegaDetectorConfigArg9,
&pimegaDetectorConfigArg10, &pimegaDetectorConfigArg11,
&pimegaDetectorConfigArg12, &pimegaDetectorConfigArg13,
&pimegaDetectorConfigArg14, &pimegaDetectorConfigArg15,
&pimegaDetectorConfigArg16, &pimegaDetectorConfigArg17,
&pimegaDetectorConfigArg18, &pimegaDetectorConfigArg19,
&pimegaDetectorConfigArg20, &pimegaDetectorConfigArg21,
&pimegaDetectorConfigArg22, &pimegaDetectorConfigArg23,
&pimegaDetectorConfigArg24};
static const iocshFuncDef configpimegaDetector = {"pimegaDetectorConfig", 25,
pimegaDetectorConfigArgs};
static void configpimegaDetectorCallFunc(const iocshArgBuf *args) {
pimegaDetectorConfig(
args[0].sval, args[1].sval, args[2].sval, args[3].sval, args[4].sval,
args[5].sval, args[6].sval, args[7].sval, args[8].sval, args[9].sval,
args[10].sval, args[11].ival, args[12].ival, args[13].ival, args[14].ival,
args[15].ival, args[16].ival, args[17].ival, args[18].ival, args[19].ival,
args[20].ival, args[21].ival, args[22].ival, args[23].ival, args[24].ival,
args[25].ival, args[26].ival);
}

While the command can be fixed, we'd suggest having information about the geometric organization of detectors supplied by pimega-api, instead of having to pass them to the driver configuration function.

@ericonr ericonr added the lumentum-v3 Issue affects lumentum-v3 branch label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lumentum-v3 Issue affects lumentum-v3 branch
Projects
None yet
Development

No branches or pull requests

1 participant