-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter opts is garbage after exiting function ccnl_mkInterest #345
Comments
theoretically yes, but once the function |
Thanks for the heads up. Honestly, I don't really like it. I've stumbled a couple times in false positives of the static analyzer where e.g. a parameter was used in a subsequent call, etc. We probably should check how we can silence these false positives or think about if we should clarify/fix these "issues". We also should probably add a new label which allows for easy filtering of these things (check if an issue identified by the static analyzer has been discussed before). Any thoughts? |
Description
In case a
NULL
pointer is passed for parameteropts
of typeccnl_interest_opts_u
in functionccnl_mkInterest
a default value is assigned. Unfortunately, the default value is local and thus resides on the stack. Hence, the value ofopts
is garbage after exiting the function, i.e.Or am I missing something?
The text was updated successfully, but these errors were encountered: