Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interest lifetime is encoded as seconds in ccnl_interest_new #210

Open
mfrey opened this issue Mar 5, 2018 · 0 comments
Open

interest lifetime is encoded as seconds in ccnl_interest_new #210

mfrey opened this issue Mar 5, 2018 · 0 comments
Assignees

Comments

@mfrey
Copy link
Collaborator

mfrey commented Mar 5, 2018

Hi,

the interest lifetime in NDN interests is set by default to CCNL_INTEREST_TIMEOUT. The constant is in seconds, but the specification states that the lifetime is milliseconds. In ccnl-relay.c

 327     /* currently, the aging function relies on seconds rather than on milli seconds */
 328     i->lifetime = (*pkt)->s.ndntlv.interestlifetime / 1000;    

The lifetime is encoded as seconds, but it should be milliseconds. I propose to set the constant CCNL_INTEREST_TIMEOUT to milliseconds and transform either the field upon reception into seconds or in the aging function (so the field is always milliseconds and nobody gets confused).

Best,
Michael

@mfrey mfrey changed the title interest lifetime is encoded as seconds/decoded as miliseconds interest lifetime is encoded as seconds Mar 5, 2018
@mfrey mfrey changed the title interest lifetime is encoded as seconds interest lifetime is encoded as seconds in ccnl_interest_new Mar 5, 2018
blacksheeep added a commit that referenced this issue Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants