Wrong ssl ipv6 check

[stofel]

ibrowse_http_client.erl line 615 is_ipv6_host(Host) use inet_parse:address(Host) which always return {error,einval}
For host with ipv4 and ipv6 resolving to ipv6 by default, but if ssl compiled without ipv6, ibrowse dosnt work

[cmullaparthi]

@stofel thanks for reporting this. I'm not sure I understand. Do you have an example to explain the problem please?

[stofel]

[alexs:bone:~]>erl
Erlang/OTP 19 [erts-8.3.5.4] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:10] [hipe] [kernel-poll:false] [dtrace]

Eshell V8.3.5.4  (abort with ^G)
1> inet_parse:address("www.google.com").
{error,einval}

1. Function inet_parse:address/1 used in ibrowse_http_client.erl line 615 for checking ipv6 and always return {error,einval}, it make ipv6 default for sites with ipv4 and ipv6
2. is_ipv6_host not check ssl ipv6 support, witch not work by default, i don`t know why, maybe need some compile or start flags

I make patch is_ipv6_host(Host) for use ipv4 by default

ibrowse/src]>git diff ibrowse_http_client.erl
diff --git a/src/ibrowse_http_client.erl b/src/ibrowse_http_client.erl
index 2b79a0e..074e9c2 100644
--- a/src/ibrowse_http_client.erl
+++ b/src/ibrowse_http_client.erl
@@ -613,11 +613,8 @@ get_sock_options(Host, Options, SSLOptions) ->
     end.

 is_ipv6_host(Host) ->
-    case inet_parse:address(Host) of
-        {ok, {_, _, _, _, _, _, _, _}} ->
-            true;
-        {ok, {_, _, _, _}} ->
-            false;
+    case inet:gethostbyname(Host) of
+        {ok, #hostent{h_addrtype = inet}} -> false;
         _  ->
             case inet:gethostbyname(Host, inet6) of
                 {ok, #hostent{h_addrtype = inet6}} ->

[dch]

BTW this was fixed by 555f707