fix: make HashUtil::HashBytes more platform independent (#814)

polyominal · connortsui20 · web-flow · commit 53b85bbbf2dc · 2025-05-13T15:16:18.000-04:00
Co-authored-by: Connor Tsui &lt;87130162+connortsui20@users.noreply.github.com&gt;
diff --git a/src/include/common/util/hash_util.h b/src/include/common/util/hash_util.h
@@ -33,7 +33,7 @@ class HashUtil {
     // https://github.com/greenplum-db/gpos/blob/b53c1acd6285de94044ff91fbee91589543feba1/libgpos/src/utils.cpp#L126
     hash_t hash = length;
     for (size_t i = 0; i < length; ++i) {
-      hash = ((hash << 5) ^ (hash >> 27)) ^ bytes[i];
+      hash = ((hash << 5) ^ (hash >> 27)) ^ static_cast<int8_t>(bytes[i]);
     }
     return hash;
   }

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ class HashUtil {`
`33`	`33`	`// https://github.com/greenplum-db/gpos/blob/b53c1acd6285de94044ff91fbee91589543feba1/libgpos/src/utils.cpp#L126`
`34`	`34`	`hash_t hash = length;`
`35`	`35`	`for (size_t i = 0; i < length; ++i) {`
`36`		`- hash = ((hash << 5) ^ (hash >> 27)) ^ bytes[i];`
	`36`	`+ hash = ((hash << 5) ^ (hash >> 27)) ^ static_cast<int8_t>(bytes[i]);`
`37`	`37`	`}`
`38`	`38`	`return hash;`
`39`	`39`	`}`