-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1 filters using P2GT for tau paths #45041
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45041/40345
|
A new Pull Request was created by @agrubercms for master. It involves the following packages:
@Martin-Grunewald, @mmusich, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Ciao @smuzaffar I'd like to test this PR using this. |
enable hlt_p2_timing |
@cmsbuild please test |
Apparently so. |
Noo!!! You have stolen my first run!!! 😭 |
So sorry! |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d92aed/39519/summary.html
Comparison SummarySummary:
|
-1.5s, not bad! -22% of (useless) timing. |
@agrubercms please remove the Draft label from this PR as soon as you have verified the efficiency. Any ETA for this? |
Hi @rovere, |
hold
|
Pull request has been put on hold by @mmusich |
That would be a surprise: in all slides presented by L1T, the turn-on for taus is quite sharp and the plateau is at 90+% or so see here, page 19. Let's wait for your studies. Next week at the HLT Upgrade meeting is ok. |
Hi there, just saw this (from the tsg slides). |
@rovere while you are right about the higher efficiency in the plateau, note that for low pt taus the efficiency is not that high. And from these HLT paths it seems the thresholds are below the expected gen pt plateau (52 GeV as in the L1 seed name). |
Hi @artlbv, |
Report regarding the efficiency available in HLT Upgrade. |
unhold |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds an L1 filter based on the L1P2GT for the Phase-2 tau HLT paths.
As reported in HLT Upgrade, we see lower efficiency upon including the L1 filter, but it achieves a great speed-up in the HLT menu timing, and an L1 filter will be needed eventually in any case (Also, the integration of new L1 tau seeds, once available, will be straightforward after this PR).
PR validation: