Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Computation of silicon strip hit efficiency : Consecutive missing hits recovery #45014

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 22, 2024

backport of #45008
backport of #44858

PR description:

This PR is a combined backport.
The goal is s apply in the 2024 data-taking release the correction introduced in PR #44858 to both the SiStripHitEfficiencyWorker module which is run as part of the PromptCalibProdSiStripHitEff Prompt Calibration Loop workflow and the standalone HitEff class used in the SiStrip Calibration trees.
Features introduced (as per #44858 (comment)):

  • Improvement of the missing hits recovery within the strips, to take into account two consecutive missing hits when one is located in an inactive modules;
  • Expected output is a slight change in the hit efficiency per layer, as shown in the slides presented during the Strip calibration and local reconstruction meeting here ( Recovery of consecutive missing hits )

PR validation:

See #45008 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim combined backport of #45008 and #44858

@mmusich
Copy link
Contributor Author

mmusich commented May 22, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • CalibTracker/SiStripHitEfficiency (alca)

@perrotta, @cmsbuild, @consuegs, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@gbenelli, @robervalwalsh, @yuanchao, @tocheng, @mmusich, @rsreds, @echabert this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented May 22, 2024

test parameters:

  • workflows = 1001, 1001.2, 1001.3, 1001.4, 1002.3

@mmusich
Copy link
Contributor Author

mmusich commented May 22, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c35a3e/39462/summary.html
COMMIT: 6ecb94d
CMSSW: CMSSW_14_0_X_2024-05-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45014/39462/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit beb792c into cms-sw:CMSSW_14_0_X May 28, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_DenkMybu_HitsRecovery_14_0_X branch May 28, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants