Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic parameter #82

Closed
wants to merge 16 commits into from
Closed

Conversation

wiseelf
Copy link

@wiseelf wiseelf commented May 29, 2024

what

  • added new variable parameter
  • value of variable max_item_size was added as default value to parameter
  • added dynamic block to aws_elasticache_parameter_group resource

why

  • To add ability to configure Memcached parameter group.

references

@wiseelf wiseelf requested review from a team as code owners May 29, 2024 12:33
@wiseelf wiseelf requested review from kevcube and joe-niland May 29, 2024 12:33
@mergify mergify bot added the triage Needs triage label May 29, 2024
@sknmi
Copy link

sknmi commented Jan 3, 2025

We've switched to https://github.com/terraform-aws-modules/terraform-aws-elasticache which already supports this feature instead of waiting for this to be merged for years.

Copy link
Contributor

mergify bot commented Feb 2, 2025

💥 This pull request now has conflicts. Could you fix it @wiseelf? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Feb 2, 2025
@mergify mergify bot closed this Feb 2, 2025
Copy link
Contributor

mergify bot commented Feb 2, 2025

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot removed conflict This PR has conflicts triage Needs triage labels Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configuration of other engine parameters
4 participants