Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update module to use new ALB ingress module #126

Closed
wants to merge 4 commits into from
Closed

feat: update module to use new ALB ingress module #126

wants to merge 4 commits into from

Conversation

jhosteny
Copy link
Contributor

This change updates the ALB ingress module so that we can pass the OIDC
scope setting through unaltered.

Fixes #90.

what

  • Update the module to use the latest alb-ingress module, which passes through the OIDC scopes as a string

why

  • Be compatible with the scope changes in the alb-ingress module, which were meant to reduce the burden on the module for properly formatted scope strings

references

@jhosteny jhosteny requested review from a team as code owners February 25, 2021 18:48
jhosteny
jhosteny commented Feb 25, 2021
View reviewed changes
README.md Show resolved Hide resolved
jhosteny
jhosteny commented Feb 25, 2021
View reviewed changes
README.md Show resolved Hide resolved
jamengual
jamengual reviewed Feb 25, 2021
View reviewed changes
context.tf Outdated Show resolved Hide resolved
@jhosteny
feat: update module to use new ALB ingress module
1b78fc3 
This change updates the ALB ingress module so that we can pass the OIDC
scope setting through unaltered.

Fixes cloudposse#90.
@jamengual
Copy link
Contributor

/test all

@jhosteny
Copy link
Contributor Author

/test all

jamengual
jamengual previously approved these changes Feb 25, 2021
View reviewed changes
nitrocode
nitrocode previously approved these changes Feb 25, 2021
View reviewed changes
@jhosteny jhosteny dismissed stale reviews from nitrocode and jamengual via 8193902 March 3, 2021 14:48
@nitrocode
Copy link
Member

Might as well upgrade the source to the latest version of the alb ingress module

@jhosteny
Copy link
Contributor Author

jhosteny commented Mar 7, 2021

/test all

@nitrocode
Copy link
Member

Also remove this from the README.yaml

    alb_ingress_unauthenticated_listener_arns_count = 1

@jamengual jamengual closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual left review comments

@nitrocode nitrocode nitrocode left review comments

@woz5999 woz5999 Awaiting requested review from woz5999

@RothAndrew RothAndrew Awaiting requested review from RothAndrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update module according to new ALB ingress scope semantics
3 participants
@jhosteny @jamengual @nitrocode