Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codestar_connection_arn (Github Version 2) not working. #98

Open
tom126p opened this issue Oct 11, 2021 · 1 comment
Open

codestar_connection_arn (Github Version 2) not working. #98

tom126p opened this issue Oct 11, 2021 · 1 comment

Comments

@tom126p
Copy link

tom126p commented Oct 11, 2021

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Slack Community

Describe the Feature

Cannot use codestar_connection_arn to authenticate to Github as source for CICD static website. Must use (Github Version 1) and manually log in inside console after deployment.

Works perfectly with:
module "ecs_codepipeline" {
source = "cloudposse/ecs-codepipeline/aws"
codestar_connection_arn = var.codestar_connection_arn

A clear and concise description of what the bug is.

Expected Behavior

Doesn't seem to be coded in .terraform

A clear and concise description of what you expected to happen.

Use Case

Is your feature request related to a problem/challenge you are trying to solve? Please provide some additional context of why this feature or capability will be valuable.

Describe Ideal Solution

A clear and concise description of what you want to happen. If you don't know, that's okay.

Alternatives Considered

Explain what alternative solutions or features you've considered.

Additional Context

Add any other context or screenshots about the feature request here.

@nitrocode
Copy link
Member

nitrocode commented Jun 22, 2022

Yep you're right.

From ecs codepipeline, there is a separate codepipeline resource that gets created.

https://github.com/cloudposse/terraform-aws-ecs-codepipeline/blob/13332037cb896137ae6dc09f3efa823c48300bc2/main.tf#L355

Instead of having two hard resources in both modules, it would be good to have it consolidated in a single module. 🤔

In spite of the other module containing ecs in the title, it doesnt do much with the ecs input. If the ecs input was optional then that module could be the generic codepipeline module that could be reused by this module (if this one is still relevant).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants