address comments, add tests

Author: aknysh

pkg/config/load_error_paths_test.go

@@ -222,8 +222,8 @@ func TestLoadConfigFile_ConfigFileNotFoundError(t *testing.T) {
 
 // TestReadConfigFileContent_ReadError tests error path at load.go:308-312.
 func TestReadConfigFileContent_ReadError(t *testing.T) {
-	// Try to read a nonexistent file
-	_, err := readConfigFileContent("/nonexistent/path/atmos.yaml")
+	// Try to read a nonexistent file.
+	_, err := readConfigFileContent(filepath.Join(string(os.PathSeparator), "nonexistent", "path", "atmos.yaml"))
 	assert.Error(t, err)
 	assert.ErrorIs(t, err, errUtils.ErrReadConfig)
 }
@@ -441,8 +441,8 @@ func TestMergeConfigFile_ReadFileError(t *testing.T) {
 	v := viper.New()
 	v.SetConfigType("yaml")
 
-	// Try to read non-existent file
-	err := mergeConfigFile("/nonexistent/path/config.yaml", v)
+	// Try to read non-existent file.
+	err := mergeConfigFile(filepath.Join(string(os.PathSeparator), "nonexistent", "path", "config.yaml"), v)
 	assert.Error(t, err)
 }
 

toolchain/installer/extract.go

@@ -245,6 +245,9 @@ func (i *Installer) extractFilesFromDir(tempDir, binaryPath string, tool *regist
 			// Try with .exe extension (common for Windows binaries in archives).
 			srcWithExe := src + windowsExeExt
 			if _, exeErr := os.Stat(srcWithExe); exeErr != nil {
+				if !os.IsNotExist(exeErr) {
+					return fmt.Errorf("%w: failed to stat file in archive: %s: %w", ErrFileOperation, srcWithExe, exeErr)
+				}
 				return fmt.Errorf("%w: file not found in archive: %s", ErrToolNotFound, expandedSrcPath)
 			}
 			src = srcWithExe