Add support for setting app lifecycle #481
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This actually looks pretty good, better than a lot of PRs I've seen over the years. I think the build test might have been modified incorrectly, but I'll have to look a little closer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to add support for using the CNB lifecycle when pushing apps using the Terraform provider, which uses this CF client library. I thought it would be best to first have CNB lifecycle support exist here in the client that the Terraform provider uses.
Confession time 🥺👉👈 : I am not a good Go programmer, but GitHub Copilot claims to be. I don't personally see any problems with the code it generated, but not being an expert in Go code, tooling, and testing facilities, it's possible and even likely that I missed something. Please let me know if you see problems or want changes!