-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destroy on cloudflare_authenticated_origin_pulls disables instead of deleting #4648
Comments
Community NoteVoting for Prioritization
Volunteering to Work on This Issue
|
Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of This issue has been marked with |
…or nil) in order for the association to be destroyed. Setting this to false keeps the association in a disabled state instead of destroying the resource. Documentation on this API endpoint can be found here: https://developers.cloudflare.com/api/operations/per-hostname-authenticated-origin-pull-enable-or-disable-a-hostname-for-client-authentication Referencing issue raised on provider: cloudflare#4648
…or nil) in order for the association to be destroyed. Setting this to false keeps the association in a disabled state instead of destroying the resource. Documentation on this API endpoint can be found here: https://developers.cloudflare.com/api/operations/per-hostname-authenticated-origin-pull-enable-or-disable-a-hostname-for-client-authentication Referencing issue raised on provider: cloudflare#4648
the API docs state that in order to delete an instance the enabled flag must be set to null. API docs can be found here: https://developers.cloudflare.com/api/operations/per-hostname-authenticated-origin-pull-enable-or-disable-a-hostname-for-client-authentication This fix is required to correct an issue with the cloudflare terraform provider which is currently failing to destroy these resources correctly. This can lead to a hard lock of mtls certificates and origin pulls configured on them as the cloudflare API contains validation bugs on the endpoint documented on the URL above. Issue raised on the terraform provider: cloudflare/terraform-provider-cloudflare#4648 PR raised to fix this on the terraform provider: cloudflare/terraform-provider-cloudflare#4649
the API docs state that in order to delete an instance the enabled flag must be set to null. API docs can be found here: https://developers.cloudflare.com/api/operations/per-hostname-authenticated-origin-pull-enable-or-disable-a-hostname-for-client-authentication This fix is required to correct an issue with the cloudflare terraform provider which is currently failing to destroy these resources correctly. This can lead to a hard lock of mtls certificates and origin pulls configured on them as the cloudflare API contains validation bugs on the endpoint documented on the URL above. Issue raised on the terraform provider: cloudflare/terraform-provider-cloudflare#4648 PR raised to fix this on the terraform provider: cloudflare/terraform-provider-cloudflare#4649
…or nil) in order for the association to be destroyed. Setting this to false keeps the association in a disabled state instead of destroying the resource. Documentation on this API endpoint can be found here: https://developers.cloudflare.com/api/operations/per-hostname-authenticated-origin-pull-enable-or-disable-a-hostname-for-client-authentication Referencing issue raised on provider: cloudflare#4648
Marking this issue as stale due to 30 days of inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the |
Confirmation
Terraform and Cloudflare provider version
Terraform: 1.6.6
Provider: 4.46.0
Affected resource(s)
cloudflare_authenticated_origin_pulls
Terraform configuration files
Link to debug output
N/A
Panic output
No response
Expected output
Enabled flag set to null as per the documentation: https://developers.cloudflare.com/api/operations/per-hostname-authenticated-origin-pull-enable-or-disable-a-hostname-for-client-authentication
Actual output
Enabled flag set to false, which disables the association but does not destroy it - see documentation: https://developers.cloudflare.com/api/operations/per-hostname-authenticated-origin-pull-enable-or-disable-a-hostname-for-client-authentication
Steps to reproduce
curl -X GET "https://api.cloudflare.com/client/v4/zones/${cloudflare_zone}/origin_tls_client_auth/hostnames?page=${page}" --header "X-Auth-Email: $CLOUDFLARE_USER" --header "X-Auth-Key: $CLOUDFLARE_KEY"
Additional factoids
See: https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/internal/sdkv2provider/resource_cloudflare_authenticated_origin_pulls.go#L126
References
No response
The text was updated successfully, but these errors were encountered: