Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DC tests don't validate certificates #130

Open
jhoyla opened this issue Aug 16, 2022 · 2 comments
Open

DC tests don't validate certificates #130

jhoyla opened this issue Aug 16, 2022 · 2 comments

Comments

@jhoyla
Copy link
Contributor

jhoyla commented Aug 16, 2022 •
edited
Loading

In delegated_credentials_test.go TestDCHandshakeServerAuth sets clientConfig.InsecureSkipVerify = true. Because of how golang handles global state this is propagated to all later tests. This leads to test failures if the tests are run in a different order or individually.
This means that even if you put bit flips into the test certificate signatures the tests will still pass.
@jhoyla jhoyla mentioned this issue Aug 16, 2022
Merged
jhoyla added a commit that referenced this issue Aug 17, 2022
@jhoyla
Fix DC implementation, addresses issues #127, #128, #129, and #130.
69f28db 
Add tool for generating delegated credentials.
jhoyla added a commit that referenced this issue Aug 17, 2022
@jhoyla
Fix DC implementation #131
fcd6ea9 
Addresses issues #127, #128, #129, and #130.
Add tool for generating delegated credentials.
@claucece
Copy link
Contributor

This was fixed in the kemtls branch. There was also another bug that was also fixed on that branch (I can't remember it anymore as it was a year ago). I also changed the API to something way nicer there, so that is def the code to use. It never got merged due to the debate of if kemtls should be in the main branch or not.

@claucece
Copy link
Contributor

I'll take a look tomorrow and compare the code.. and let you know if there is a bug that needs solving in main branch.

bwesterb pushed a commit that referenced this issue Sep 7, 2022
@jhoyla @bwesterb
Fix DC implementation #131
abb10c1 
Addresses issues #127, #128, #129, and #130.
Add tool for generating delegated credentials.
bwesterb pushed a commit that referenced this issue Sep 8, 2022
@claucece @jhoyla @bwesterb
crypto/tls: implement draft-ietf-tls-subcerts-10
8c42a69 
* Define API for delegated credentials so they are fetched using the
  same mechanisms used to fetch certificates
* Allow the usage of other keyUsage when checking for the dc extension.

Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131.
Add tool for generating delegated credentials.

Co-authored-by: jhoyla <[email protected]>
bwesterb pushed a commit that referenced this issue Oct 5, 2022
@claucece @jhoyla @bwesterb
crypto/tls: implement draft-ietf-tls-subcerts-10
845b9aa 
* Define API for delegated credentials so they are fetched using the
  same mechanisms used to fetch certificates
* Allow the usage of other keyUsage when checking for the dc extension.

Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131.
Add tool for generating delegated credentials.

Co-authored-by: jhoyla <[email protected]>
bwesterb pushed a commit that referenced this issue Nov 1, 2022
@claucece @jhoyla @bwesterb
crypto/tls: implement draft-ietf-tls-subcerts-10
cf7f104 
* Define API for delegated credentials so they are fetched using the
  same mechanisms used to fetch certificates
* Allow the usage of other keyUsage when checking for the dc extension.

Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131.
Add tool for generating delegated credentials.

Co-authored-by: jhoyla <[email protected]>
bwesterb pushed a commit that referenced this issue Dec 7, 2022
@claucece @jhoyla @bwesterb
crypto/tls: implement draft-ietf-tls-subcerts-10
94f99bd 
* Define API for delegated credentials so they are fetched using the
  same mechanisms used to fetch certificates
* Allow the usage of other keyUsage when checking for the dc extension.

Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131.
Add tool for generating delegated credentials.

Co-authored-by: jhoyla <[email protected]>
Lekensteyn pushed a commit that referenced this issue Jan 17, 2023
@claucece @jhoyla @Lekensteyn
crypto/tls: implement draft-ietf-tls-subcerts-10
f1691ca 
* Define API for delegated credentials so they are fetched using the
  same mechanisms used to fetch certificates
* Allow the usage of other keyUsage when checking for the dc extension.

Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131.
Add tool for generating delegated credentials.

Co-authored-by: Jonathan Hoyland <[email protected]>
Lekensteyn pushed a commit that referenced this issue Jan 17, 2023
@claucece @jhoyla @Lekensteyn
crypto/tls: implement draft-ietf-tls-subcerts-10
8b9ee58 
* Define API for delegated credentials so they are fetched using the
  same mechanisms used to fetch certificates
* Allow the usage of other keyUsage when checking for the dc extension.

Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131.
Add tool for generating delegated credentials.

Co-authored-by: Jonathan Hoyland <[email protected]>
Lekensteyn pushed a commit that referenced this issue Jan 19, 2023
@claucece @jhoyla @Lekensteyn
crypto/tls: implement draft-ietf-tls-subcerts-10
ccb8370 
* Define API for delegated credentials so they are fetched using the
  same mechanisms used to fetch certificates
* Allow the usage of other keyUsage when checking for the dc extension.

Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131.
Add tool for generating delegated credentials.

Co-authored-by: Jonathan Hoyland <[email protected]>
bwesterb pushed a commit that referenced this issue Feb 15, 2023
@claucece @jhoyla @bwesterb
crypto/tls: implement draft-ietf-tls-subcerts-10
b26e4d3 
* Define API for delegated credentials so they are fetched using the
  same mechanisms used to fetch certificates
* Allow the usage of other keyUsage when checking for the dc extension.

Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131.
Add tool for generating delegated credentials.

Co-authored-by: Jonathan Hoyland <[email protected]>
bwesterb pushed a commit that referenced this issue Mar 1, 2023
@claucece @jhoyla @bwesterb
crypto/tls: implement draft-ietf-tls-subcerts-10
837ca0c 
* Define API for delegated credentials so they are fetched using the
  same mechanisms used to fetch certificates
* Allow the usage of other keyUsage when checking for the dc extension.

Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131.
Add tool for generating delegated credentials.

Co-authored-by: Jonathan Hoyland <[email protected]>
bwesterb pushed a commit that referenced this issue Mar 2, 2023
@claucece @jhoyla @bwesterb
crypto/tls: implement draft-ietf-tls-subcerts-10
19948d4 
* Define API for delegated credentials so they are fetched using the
  same mechanisms used to fetch certificates
* Allow the usage of other keyUsage when checking for the dc extension.

Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131.
Add tool for generating delegated credentials.

Co-authored-by: Jonathan Hoyland <[email protected]>
Lekensteyn pushed a commit that referenced this issue May 8, 2023
@claucece @jhoyla @Lekensteyn
crypto/tls: implement draft-ietf-tls-subcerts-10
ce38500 
* Define API for delegated credentials so they are fetched using the
  same mechanisms used to fetch certificates
* Allow the usage of other keyUsage when checking for the dc extension.

Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131.
Add tool for generating delegated credentials.

Co-authored-by: Jonathan Hoyland <[email protected]>
Lekensteyn pushed a commit that referenced this issue May 10, 2023
@claucece @jhoyla @Lekensteyn
crypto/tls: implement draft-ietf-tls-subcerts-10
c8f4a7e 
* Define API for delegated credentials so they are fetched using the
  same mechanisms used to fetch certificates
* Allow the usage of other keyUsage when checking for the dc extension.

Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131.
Add tool for generating delegated credentials.

Co-authored-by: Jonathan Hoyland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhoyla @claucece