Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting not returned with defaultSorting #290

Open
lucianholt97 opened this issue Jan 30, 2019 · 3 comments
Open

Sorting not returned with defaultSorting #290

lucianholt97 opened this issue Jan 30, 2019 · 3 comments

Comments

@lucianholt97
Copy link
Contributor

When I don't specify sorting in the request, but have defaultSorting set in the Adapter, the response does not contain the meta.sorting object. Therefor my js table does not know the sorting...

Is there any way I can fix it or is it a bug?

@lindyhopchris
Copy link
Member

Hi!

the meta.sorting object

Not sure what you mean by this? There is no defined meta sorting object.

I think your question is related to #225 - is that what you're looking for?

@lucianholt97
Copy link
Contributor Author

Thank you for your quick reply!
It is not quite what I am looking for.
In my mind, the default sorting should be set on the server an not in JS. Therefor it would be handy if the api attached the sorting object to the meta data.
A workaround like you linked is not quite nice... I think the sorting data is as essential as the pagination data.

@lindyhopchris
Copy link
Member

Ah I more meant that #225 was about being able to set meta from multiple places - including being able to pass meta out of the adapter (which at the moment is only allowed for pagination).

I totally agree with you, the developer should be able to return meta from the adapter. I think this will be solved when I solve #225 in a future version. At the moment it's not possible so the safest thing for you to do is to always send a sort parameter from the client (Javascript) so that your Javascript always knows what the sort order is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants