Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle IndexError when reading msg files #671

Merged
merged 11 commits into from
Jun 19, 2024

Conversation

viktorerlingsson
Copy link
Member

@viktorerlingsson viktorerlingsson commented May 7, 2024

WHAT is this pull request doing?

Handles a case where a msg file size is bigger than expected. Tries to move on to the next segment if possible.

fixes: #669

HOW can this pull request be tested?

Run spec

Copy link
Member

@carlhoerberg carlhoerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be more generic than just BytesMessage::MIN_BYTESIZE

@viktorerlingsson viktorerlingsson changed the title msg file size does not match IndexError when reading msg file Jun 19, 2024
@viktorerlingsson viktorerlingsson changed the title IndexError when reading msg file Handle IndexError when reading msg file Jun 19, 2024
@viktorerlingsson viktorerlingsson changed the title Handle IndexError when reading msg file Handle IndexError when reading msg files Jun 19, 2024
@viktorerlingsson viktorerlingsson marked this pull request as ready for review June 19, 2024 15:24
@viktorerlingsson viktorerlingsson merged commit 1db4c6c into main Jun 19, 2024
23 of 25 checks passed
@viktorerlingsson viktorerlingsson deleted the 669-msg_size_does_not_match branch June 19, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of the queues are closed
2 participants