Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Network Manager Resource w/ Core & Global #9514

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

AWS Network Manager Resource w/ Core & Global #9514

wants to merge 18 commits into from

Conversation

zkarpinski
Copy link
Contributor

@zkarpinski zkarpinski commented May 18, 2024 •
edited

Adds support for AWS Network Manager resource. Including Core Network and Global Network.
Closes #9511 #9512 & #9513

GlobalNetwork

  • DescribeGlobalNetworks
  • TagResource
  • UntagResource
  • DeleteGlobalNetwork

Core Network

  • ListCoreNetworks
  • GetCoreNetwork
  • TagResource
  • UntagResource
  • DeleteCoreNetwork

@zkarpinski zkarpinski marked this pull request as ready for review May 18, 2024 19:28
@zkarpinski zkarpinski requested a review from kapilt as a code owner May 18, 2024 19:28
@zkarpinski zkarpinski marked this pull request as draft May 21, 2024 14:46
@zkarpinski zkarpinski marked this pull request as ready for review May 21, 2024 18:35
jerryhxu
jerryhxu suggested changes May 31, 2024
View reviewed changes
Copy link
Contributor

@jerryhxu jerryhxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also implement mark-for-op and marked-for-op as part of tagging functionality.

c7n/resources/networkmanager.py Outdated Show resolved Hide resolved
c7n/resources/networkmanager.py Outdated Show resolved Hide resolved
c7n/resources/networkmanager.py Outdated Show resolved Hide resolved
@zkarpinski zkarpinski requested a review from jerryhxu June 5, 2024 03:18
jerryhxu
jerryhxu suggested changes Jun 5, 2024
View reviewed changes
c7n/resources/networkmanager.py Outdated Show resolved Hide resolved
@zkarpinski zkarpinski requested a review from jerryhxu June 5, 2024 18:49
jerryhxu
jerryhxu suggested changes Jun 6, 2024
View reviewed changes
c7n/resources/networkmanager.py Outdated Show resolved Hide resolved
c7n/resources/networkmanager.py Outdated Show resolved Hide resolved
c7n/resources/networkmanager.py Outdated Show resolved Hide resolved
jerryhxu
jerryhxu suggested changes Jun 6, 2024
View reviewed changes
c7n/resources/networkmanager.py Outdated Show resolved Hide resolved
@zkarpinski zkarpinski requested a review from jerryhxu June 7, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapilt kapilt Awaiting requested review from kapilt kapilt is a code owner

@jerryhxu jerryhxu Awaiting requested review from jerryhxu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AWS NetworkManager Resource Type
2 participants
@zkarpinski @jerryhxu