Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor - extract utility function from query merge #9469

Open
kapilt opened this issue Apr 26, 2024 · 0 comments · May be fixed by #9533
Open

refactor - extract utility function from query merge #9469

kapilt opened this issue Apr 26, 2024 · 0 comments · May be fixed by #9533

Comments

@kapilt
Copy link
Collaborator

kapilt commented Apr 26, 2024

I've seen a few cases where we have this duplicated block when the resource supports server side query filtering, extracting to a utility function would be nice

for q in self.queries:
            if q is None:
                 continue
             query = query or {}
             for k, v in q.items():
                 query[k] = v
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant