Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight stacked discard macros #17

Open
axvr opened this issue May 5, 2021 · 0 comments · Fixed by #20
Open

Highlight stacked discard macros #17

axvr opened this issue May 5, 2021 · 0 comments · Fixed by #20
Labels
help wanted Extra attention is needed highlighting Affects syntax highlighting

Comments

@axvr
Copy link
Member

axvr commented May 5, 2021

Currently the syntax highlighting support for the discard reader macro (#_) is limited to a single form, however Clojure supports stacking them which comments out subsequent forms.

;; Correctly highlighted:
(defn foo [x]
  {:bar  (+ x 1)
   #_:biz #_(* x 2)})

;; Incorrectly highlighted:
(defn foo [x]
  {:bar (+ x 1)
   #_#_:biz (* x 2)})

It may not be possible to implement this behaviour, but is worth trying. If it isn't possible (to do efficiently) we may just disable the existing comment reader macro highlighting support by default for consistency.

@axvr axvr changed the title Support stacking of the comment reader macro Highlight stacked comment reader macros May 5, 2021
@axvr axvr changed the title Highlight stacked comment reader macros Highlight stacked discard macros Oct 15, 2021
@axvr axvr added enhancement New feature or request help wanted Extra attention is needed labels Oct 17, 2021
axvr added a commit that referenced this issue Oct 18, 2021
Disabled by default because we are currently unable to correctly
highlight stacked discard reader macros.

Related: #17
axvr added a commit that referenced this issue Oct 18, 2021
Disabled by default because we are currently unable to correctly
highlight stacked discard reader macros.

Related: #17
@axvr axvr closed this as completed in #20 Oct 26, 2021
axvr added a commit that referenced this issue Oct 26, 2021
…20)

Disabled by default because we are currently unable to correctly
highlight stacked discard reader macros.

Related: #17
@axvr axvr reopened this Oct 26, 2021
@axvr axvr added highlighting Affects syntax highlighting and removed enhancement New feature or request labels Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed highlighting Affects syntax highlighting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant