-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename protocol parameters #1692
Comments
I wonder if that's the desired behavior always but maybe most of the time, what if someone wants to rename only the local var of |
The protocol declaration never has a body, so there would be no benefit to invoking a rename action vs just renaming the symbol directly! |
Yeah, for protocols that sounds safe |
Per ericdallo's directions
Although inconsequential, it's sometimes useful to have all the implementation parameter names match the definition's.
Describe the solution you'd like
When we rename a protocol's parameter declaration, all the known implementation's parameters would be renamed accordingly.
Describe alternatives you've considered
Search-and-replace would certainly work, but protocols parameters frequently have very abstract names (
this
,coll
,el
) that are frequently found in various unrelated places.Additional context
I originally attempted to use LSP to rename a protocol's
t
tothis
in a large codebase because search-and-replace was matching various othert
s (standing fortimestamp
)The text was updated successfully, but these errors were encountered: