Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for spec-alpha2? #261

Open
alexander-yakushev opened this issue May 1, 2024 · 4 comments
Open

Support for spec-alpha2? #261

alexander-yakushev opened this issue May 1, 2024 · 4 comments
Labels
question Further information is requested

Comments

@alexander-yakushev
Copy link
Member

It looks like the development of clojure spec-alpha2 (also widely and hilariously known as clojure.alpha.spec) is stalled for now (as confirmed by Alex Miller too: https://clojurians.slack.com/archives/C03S1KBA2/p1679924331305749?thread_ts=1679878261.044279&cid=C03S1KBA2). The library doesn't have a JAR release and not even a single git tag.

Orchard supports it nominally in orchard.spec.

Two questions:

  1. How important is having support for an almost-abandoned alpha library?
  2. If the support for it desired, how important is to test against it? We currently have to clone that repository in each CI job for dubious benefits.
@alexander-yakushev alexander-yakushev added the question Further information is requested label May 1, 2024
@vemv
Copy link
Member

vemv commented May 1, 2024

Apparently the Spec browser supports Spec 2 https://docs.cider.mx/cider/usage/misc_features.html#browsing-the-clojure-spec-registry

I also know of misc professional projects that use Spec 2.

Perhaps a matrix trimming might be welcome (as long as that work isn't burdensome to you), otherwise I haven't observed a practical problem.

Worth noting, we always encourage running make test as the standard command across projects, so we shouldn't be too concerned about what's inside.

@alexander-yakushev
Copy link
Member Author

I also know of misc professional projects that use Spec 2.

😱

It's just a bit annoying having to do a special dance for a single library that never left alpha to ensure that the only one unit test written for it works.

@vemv
Copy link
Member

vemv commented May 1, 2024

Some low-hanging fruit is that if locally one runs make test twice, one is cleaning twice so the clone will be performed twice.

@vemv
Copy link
Member

vemv commented May 1, 2024

We also could use lein-git-down, it's a "xs" task, can do for you if you consider things painful locally

(Personally I don't)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants