Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment-add value is different from clojure-mode #26

Open
Andre0991 opened this issue Nov 22, 2023 · 1 comment
Open

comment-add value is different from clojure-mode #26

Andre0991 opened this issue Nov 22, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Andre0991
Copy link

comment-add is 1 in clojure-mode 1, whereas clojure-ts-mode does not set it in clojure-ts-mode-variables. This affects how many ; are added when using comment-region (see the full explanation below).

I guess it would make sense to simply reproduce clojure-mode settings.
I can open a PR for that, if it's the case.

What do you think?

Thanks!


comment-add is a variable defined in ‘newcomment.el’.

Its value is 1
Local in buffer clojure-mode.el; global value is 0

How many more comment chars should be inserted by ‘comment-region’.
This determines the default value of the numeric argument of ‘comment-region’.
The ‘plain’ comment style doubles this value.
@dannyfreeman
Copy link
Contributor

sorry for very late comment. Feel free to open up a PR, if not I can do it at some point. Thank you for opening up the issue.

@dannyfreeman dannyfreeman added the good first issue Good for newcomers label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants