Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci chore: move to version tag triggered release scheme #529

Open
lread opened this issue Mar 8, 2023 · 1 comment
Open

ci chore: move to version tag triggered release scheme #529

lread opened this issue Mar 8, 2023 · 1 comment

Comments

@lread
Copy link
Collaborator

lread commented Mar 8, 2023

Noticed that I still have a GitHub Actions GUI triggered release strategy here.

This is a reminder to switch to a git version tag triggered release scheme, which is the preference of those with an interest on the clj-commons team.

This work was recently done on pomegranate and even more recently rewrite-clj.
So I'll steal from those projects.

@lread
Copy link
Collaborator Author

lread commented Mar 10, 2023

Note to self: look at refining how the publish flow is triggered.

We want it triggered by a new version tag, but ideally, we don't want this triggering to happen from forks. It's not the end of the world to do this, the attempt to publish will fail, but it is confusing and annoying for contributors when all they've done is innocently synched with upstream.

I've done a bit of digging, and I don't see anything at the workflow level, but at the job level, we might be able to add a check like:

if: github.repository_owner == 'clj-commons'

To skip all jobs in the publish flow unless it is run from clj-commons.

lread added a commit that referenced this issue Mar 11, 2023
Apply learnings from experiments in my muckabout project.
I think I've got the right incantations, but will adapt if I learn otherwise.

I would have rather applied some skipping at the workflow level, but
some things can only be skipped at the job level. Only need to apply
`if` skipping to the setup job, if it is skipped, dependent build job
will also be skipped.

Closes #533
Includes some intelligence that will be used by #529.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant