Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get-element-outer-html[-el] #522

Open
hendursaga opened this issue Mar 5, 2023 · 3 comments
Open

Add get-element-outer-html[-el] #522

hendursaga opened this issue Mar 5, 2023 · 3 comments

Comments

@hendursaga
Copy link

It took me too long to realize that an issue I was stuck on was because I didn't realize there wasn't a way to grab the outer HTML instead of just the inner HTML.

It would seem to be a relatively straightforward copy-and-paste job, but I figured we'd discuss this before I try and code up a PR.

@lread
Copy link
Collaborator

lread commented Mar 5, 2023

Hi @hendursaga raising an issue first is appreciated, thanks!

So etaoin.api currently exposes get-element-inner-html and get-element-inner-html-el, and you are proposing that to add get-element-outer-html and get-element-outer-html-el.

If that works across all of our supported webdriver implementations, coolio, PR welcome!

@hendursaga
Copy link
Author

hendursaga commented Mar 5, 2023

It appears it's part of the official spec, or at least, a referenced spec. I've never known an implementation to not allow grabbing the outer HTML.

In the meantime, my workaround is simply e/get-element-property driver query :outerHTML)

Is there a way for me to easily test out all these implementations? Specifically, once I get Firefox to work with the PR on my local machine, how do I set it up so that my fork of etaoin would run whatever GitHub Actions you have?

@lread
Copy link
Collaborator

lread commented Mar 5, 2023

Is there a way for me to easily test out all these implementations?

Feel free to submit a PR if you like.
We have GitHub Actions test across all supported WebDrivers and OSes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants