Delay the binding of paper for ToolView

[yfwz100]

See the code below. The paper binding could be derived from relatedView instead of binding directly. By delaying the binding of paper, the ToolView could be initialized within the initialization procedure of Link.

joint/src/dia/ToolView.mjs

Lines 62 to 67 in 7b6080d

	guard: function(evt) {
	// Let the context-menu event bubble up to the relatedView
	const { paper, relatedView } = this;
	if (!paper || !relatedView) return true;
	return paper.guard(evt, relatedView);
	}

[kumilingus]

Hi, could you please post here an example when this is an issue?

[yfwz100]

It's a structural issue rather than a functional issue. In my opinnion, link tools are attachments to links so they should be subject to links instead of papers. Therefore, I tried to encapsulate the link tools into links' constructor(initialize) but found that it failed without any errors (the guard method always returns true if paper is null or undefined).

[kumilingus]

I see. Would this help for the time being?

Object.defineProperty(joint.dia.ToolView.prototype, 'paper', {

    enumerable: true,

    get: function() {
        return this.relatedView.paper;
    },

    set: function() {
        // noop
    }

});

[yfwz100]

This polyfill works. However, there's another issue. If I put link tools in links' constructor, the link tools are always shown at the first time.

I further found the following code:

joint/src/dia/ToolsView.mjs

Lines 57 to 62 in 68481bc

	if (!isRendered) {
	this.mount();
	// Make sure tools are visible (if they were hidden and the tool removed)
	this.blurTool();
	this.isRendered = true;
	}

If the link tools are rendered the first time, it's always visible.

At present, I use a setTimeout() to delay the binding of link tools but it seems unreliable. Is there a correct phase to hide the link tools?

[yfwz100]

Extending the ToolsView can get around this issue but it's a bit ugly...

class MyToolsView extends joint.dia.ToolsView {
  get paper() {
    return this.relatedView.paper;
  }

  blurTool(...args) {
    if (!this.isRendered) {
      return; // do nothing.
    }
    super.blurTool(...args);
  }
}

[github-actions]

This issue is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.