Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim down on dependencies #3055

Open
4 tasks done
mcmxcdev opened this issue Mar 27, 2024 · 2 comments
Open
4 tasks done

Slim down on dependencies #3055

mcmxcdev opened this issue Mar 27, 2024 · 2 comments

Comments

@mcmxcdev
Copy link

mcmxcdev commented Mar 27, 2024

Preliminary Checks

Reproduction

Publishable key

Description

Looking at the package.json below, Clerk pulls in various dependencies that can probably be dropped nowadays:

"copy-to-clipboard": "3.3.3",
"core-js": "3.26.1",
"dequal": "2.0.3",
"qrcode.react": "3.1.0",
"qs": "6.11.0",
"regenerator-runtime": "0.13.11"

  • copy-to-clipboard is a one liner nowadays with navigator.clipboard.writeText()
  • core-js and regenerator-runtime are polyfill compatibility layers that most developers with modern tech-stacks don't care about
  • qs can be replaced with native URLSearchParams API
  • probably more

Expected behavior:
Project should be kept as slim as possible

Actual behavior:
End users of Clerk have to download and install more deps, which can have CVEs and require more disk space and install time.

Environment

System:
    OS: Linux 6.5 Ubuntu 23.10 23.10 (Mantic Minotaur)
    CPU: (16) x64 AMD Ryzen 7 5800H with Radeon Graphics
    Memory: 17.57 GB / 30.71 GB
    Container: Yes
    Shell: 5.9 - /usr/bin/zsh
  Binaries:
    Node: 20.11.0 - ~/.volta/tools/image/node/20.11.0/bin/node
    Yarn: 1.22.22 - ~/.volta/tools/image/yarn/1.22.22/bin/yarn
    npm: 10.2.4 - ~/.volta/tools/image/node/20.11.0/bin/npm
    pnpm: 8.14.1 - ~/.volta/tools/image/pnpm/8.14.1/bin/pnpm
  Browsers:
    Brave Browser: 123.1.64.109
    Chrome: 123.0.6312.58
  npmPackages:
     "clerk-sveltekit": "^0.4.1"c
@mcmxcdev mcmxcdev added the needs-triage A ticket that needs to be triaged by a team member label Mar 27, 2024
@dimkl
Copy link
Member

dimkl commented Mar 28, 2024

Hello @mcmxcdev
Thank you for this feedback. Indeed, it seems we can reduce the dependencies, so we will create a ticket and assign the appropriate priority.
In the meantime, if you are interested in contributing to ClerkJS we are open for PRs.

Resources:

@mcmxcdev
Copy link
Author

I appreciate the openness to my suggestions! I will consider creating some PRs if I can manage to find the time.

@jescalan jescalan added the confirmed label Apr 8, 2024 — with Linear
@jescalan jescalan removed the needs-triage A ticket that needs to be triaged by a team member label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants