Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "Tools" framework to snakemake workflows #457

Open
cleme opened this issue May 30, 2023 · 2 comments · May be fixed by #472
Open

Migrate "Tools" framework to snakemake workflows #457

cleme opened this issue May 30, 2023 · 2 comments · May be fixed by #472
Labels
AnalysisTools enhancement meta issue issue to be broken down into component issues and then linked to this one
Milestone

Comments

@cleme
Copy link
Member

cleme commented May 30, 2023

Is your feature request related to a problem? Please describe.
Including additional tools in MMEDS should be simply a matter of defining inputs, outputs, and command calls. It is unclear whether the current implementation of MMEDS is similar to this or requires ad hoc code.

Describe the solution you'd like
Review current implementation. Discuss whether it is sufficiently robust or we need an alternative approach.

@cleme cleme added enhancement AnalysisTools meta issue issue to be broken down into component issues and then linked to this one labels May 30, 2023
@cleme cleme added this to the 0.12.0 milestone May 30, 2023
@adamcantor22
Copy link
Member

We have discussed this a lot, but never written it down: all analyses should ideally be contained within snakemake files (Nextflow would be the other viable workflow system, but snakemake works out of the box with python) for easy structuring and modification. This will likely have to be the centerpiece of its own release

@adamcantor22 adamcantor22 changed the title Is the current structure optimal to add tools fo MMEDS? Migrate "Tools" framework to snakemake workflows Jun 26, 2024
@adamcantor22
Copy link
Member

For my first pull request of this release, I'll only be adding two workflows: 'standard_pipeline' and 'lefse'. This is just to establish the framework, as well as most of the generic use cases that will be used by most other workflows. Attaching here the issues for tools that will become workflows (by themselves or in conjunction with other tools) in the following pull requests:
-SparCC & Cytoscape: #307
-DMM: #378
-Batch Correction: #381 (should batch correction be automatic in the standard pipeline? should it be separate?)
-Decontam: #412
-rPCA: #443
-UMAP: #444
-RF/Lasso: #468

Others that will need to be added or re-added:
-CUTIE
-PiCRUSt2 (and BRITE)
-Mediation
-Everything shotgun related

@adamcantor22 adamcantor22 linked a pull request Aug 8, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AnalysisTools enhancement meta issue issue to be broken down into component issues and then linked to this one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants