This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Remove manifest timestamp #79
Comments
matthewrsj
added a commit
to matthewrsj/swupd-server
that referenced
this issue
Sep 28, 2017
Fixes clearlinux#79 The timestamp field is not used and is a barrier to reproducible builds. Remove the timestamp field from the manifests. Signed-off-by: Matthew Johnson <[email protected]>
In #83, I suggested that we consider adding support for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
From clearlinux/swupd-client#95:
We've never used this timestamp for anything. Manifests are meant to be immutable once created. So the timestamps should only flow forward and no issues.
In the unfortunate situation of a DevOps group needing to recreate old Manifests, they will have a new timestamp, and a changed hash relative what an old MoM (ie: assume MoM's got recreated, but some clients had downloaded and cached an old MoM, then downloaded a new bundle manifest on bundle add), which leads to an error/warn in the client at runtime.
The error/warn can be addressed via clearlinux/swupd-client#94, but that code path would also have never hit if the manifest did not have the timestamp in it.
Let's simply remove the timestamp. This can be done without a format bump.
The text was updated successfully, but these errors were encountered: