Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testlib: move non public functions to a different file, same for test fixtures #1482

Open
castulo opened this issue Apr 20, 2020 · 1 comment
Labels

Comments

@castulo
Copy link
Contributor

castulo commented Apr 20, 2020

Testlib at the moment is divided in 2 main groups:

  1. it provides test fixtures, stuff like assertions, functions to format tests, etc. All this functionality in general is independent of swupd.
  2. It also provides functions to create test resources related to swupd. These can be split in two categories: external functions (these are functions that are intended to be called directly from tests or from the terminal), and internal functions (functions that are only supposed to be used by external functions and not directly from a test or terminal).

The testlib file is getting too big now, I think it may be time to reorganize it in a way that makes more sense. Maybe into 3 different files: one for fixtures, one for internal functions and one for public functions.

@otaviobp
Copy link
Contributor

I also would create one different file that is not included by testlib that includes all functions that are not intended to be used by any test, like list_tests, generate_tests, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants