Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement Audio Description Overlay #761

Open
sujitv19196 opened this issue Dec 18, 2023 · 1 comment
Open

Reimplement Audio Description Overlay #761

sujitv19196 opened this issue Dec 18, 2023 · 1 comment

Comments

@sujitv19196
Copy link
Contributor

Problem

  • There is an audio description overlay (src/screens/Watch/Components/Overlays/AudioDescription/index.js) but it is not used

Solution

  • figure out what this is supposed to do
  • implement this into the player if it seems like a good idea
@angrave
Copy link
Collaborator

angrave commented Dec 18, 2023

The overlays have stuff set up for being front of video area. However would it make more sense to use the transcript area and augment the current caption with additional controls (prev sentence || repeat sentence || next sentence || play all || cancel/pause || continue/close)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants