Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using a direct adaptation of OneVsRestClassifier from scikit-learn in OneVsRestCalibrator #8

Open
perellonieto opened this issue Mar 24, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@perellonieto
Copy link
Member

The current function OneVsRestCalibrator https://github.com/perellonieto/PyCalib/blob/master/pycalib/models/multiclass.py#L72 uses an adapted copy of the scikit-learn OneVsRestClassifier https://github.com/scikit-learn/scikit-learn/blob/95119c13a/sklearn/multiclass.py#L138

It would be good to clarify what parts are necessary for this code, and what parts can be refactored in a way that we can use directly scikit-learn without duplicating the code.

@perellonieto perellonieto added the enhancement New feature or request label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant