Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last Commit #68

Open
giosce opened this issue May 17, 2022 · 1 comment
Open

Last Commit #68

giosce opened this issue May 17, 2022 · 1 comment

Comments

@giosce
Copy link
Collaborator

giosce commented May 17, 2022

I still see something not working 100% after @themightychris and I made a change to get the last_commit on the default branch not from Bot.

ProjectIndex shows these 2 as updated in a week:
https://github.com/BetaNYC/batch-geocoder-nyc/branches
https://github.com/18F/10x-MLaaS/branches

This is the API call for the F18 project https://api.github.com/repos/18F/10x-MLaaS/commits
I don't see a commit with date within last week in response, regardless of committer name/type. The code checks for author.type != 'Bot' and uses author.date so the code seems correct to me.

The 18F project toml has been updated recently (so there isn't a problem of not updating the toml files).

The code trying to get the last_commit is at https://github.com/codeforamerica/brigade-project-index/blob/master/crawler/lib/decorators/GitHubLastCommit.js

Actually, the snapshot is fine (has 2021 date commit) https://github.com/codeforamerica/brigade-project-index/blob/snapshot/v1/projects/18F/10x-MLaaS.toml, the "index" is wrong (saying within last week) https://github.com/codeforamerica/brigade-project-index/blob/index/v1/projects/18F/10x-MLaaS.toml

@giosce
Copy link
Collaborator Author

giosce commented Jun 15, 2022

Obviously, data keep changing. Today (6/14) I found this example.
https://github.com/codeforamerica/brigade-project-index/blob/snapshot/v1/projects/18F/charlie.toml seems wrong, last_commit is 6/3, pushed_within says week.
From the link to github from our UI, it shows "11 days ago" and I see there is a branch with a commit of "10 hours ago".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issue Review
Development

No branches or pull requests

1 participant