dev/core#5802 Initial Recurring Membership Contribution modification

Author: shaneonabike

CRM/Member/Form/Membership.php

@@ -476,6 +476,10 @@ public function buildQuickForm() {
       $this->add('number', 'num_terms', ts('Number of Terms'), ['size' => 6]);
     }
 
+    if (Civi::settings()->get('update_contribution_on_membership_type_change')) {
+      $this->addElement('checkbox', 'update_recur', ts('Update Recurring Contribution?'));
+    }
+
     $this->add('text', 'source', ts('Membership Source'),
       CRM_Core_DAO::getAttribute('CRM_Member_DAO_Membership', 'source')
     );
@@ -1315,6 +1319,10 @@ public function submit(): void {
       }
     }
 
+    $params['update_recur'] = FALSE;
+    if ($this->getSubmittedValue('update_recur')) {
+      $params['update_recur'] = $formValues['update_recur'];
+    }
     $this->updateContributionOnMembershipTypeChange($params);
 
     if (($this->_action & CRM_Core_Action::UPDATE)) {
@@ -1388,7 +1396,7 @@ protected function updateContributionOnMembershipTypeChange($inputParams) {
     // if selected membership doesn't match with earlier membership
       !in_array($this->_memType, $this->_memTypeSelected)
     ) {
-      if ($this->isCreateRecurringContribution()) {
+      if ($this->isCreateRecurringContribution() && !$inputParams['update_recur']) {
         CRM_Core_Session::setStatus(ts('Associated recurring contribution cannot be updated on membership type change.'), ts('Error'), 'error');
         return;
       }
@@ -1418,6 +1426,23 @@ protected function updateContributionOnMembershipTypeChange($inputParams) {
         $this
       );
       CRM_Core_Session::setStatus(ts('Associated contribution is updated on membership type change.'), ts('Success'), 'success');
+
+      // Update Recurring Contribution
+      if ($inputParams['update_recur']) {
+        $contribution = \Civi\Api4\Contribution::get()
+          ->addWhere('id', '=', $contributionID)
+           ->execute()
+           ->first();
+
+        if (!empty($contribution['contribution_recur_id'])) {
+          ContributionRecur::update(FALSE)
+            ->addValue('amount', $contribution['total_amount'])
+            ->addValue('currency', $contribution['currency'])
+            ->addValue('modified_date', 'now')
+            ->addWhere('id', '=', $contribution['contribution_recur_id'])
+           ->execute();
+        }
+      }
     }
   }
 

templates/CRM/Member/Form/Membership.tpl

@@ -98,6 +98,17 @@
             <span class="description">{ts}Select Membership Organization and then Membership Type.{/ts}{if $hasPriceSets} {ts}Alternatively, you can use a price set.{/ts}{/if}</span>
           </td>
         </tr>
+        {if $isRecur && '{$form.update_recur.label}'}
+        <tr id="crm-membership-form-block-update-recurring">
+          <td class="label">{$form.update_recur.label}</td>
+          <td class="mem_recur_contribution">
+             <span class="UpdateRecur">{$form.update_recur.html}</span>
+             <span class="description">
+                {ts}Update Recurring Contribution to match the current membership pricing on this change.{/ts}
+              </span>
+          </td>
+        </tr>
+        {/if}
         <tr id="maxRelated" class="crm-membership-form-block-max_related">
           <td class="label">{$form.max_related.label}</td>
           <td>{$form.max_related.html}<br />
@@ -340,6 +351,9 @@
         cj('#membership_type_id_1-readonly').text(cj('#membership_type_id_1 option:selected').text());
         cj('#mem_type_id-readonly').show();
         cj('#mem_type_id-editable').hide();
+        {if '{$form.update_recur.label}'}
+          cj('#crm-membership-form-block-update-recurring').hide();
+        {/if}
       {else}
         cj('#mem_type_id-readonly').hide();
         cj('#mem_type_id-editable').show();
@@ -350,6 +364,9 @@
         e.preventDefault();
         cj('#mem_type_id-readonly').hide();
         cj('#mem_type_id-editable').show();
+        {if '{$form.update_recur.label}'}
+          cj('#crm-membership-form-block-update-recurring').show();
+        {/if}
       });
 
       // give option to override end-date for auto-renew memberships