Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

effect adapter errors when using Schema from Effect #497

Open
1 task done
valterkraemer opened this issue Oct 31, 2024 · 5 comments · May be fixed by #522
Open
1 task done

effect adapter errors when using Schema from Effect #497

valterkraemer opened this issue Oct 31, 2024 · 5 comments · May be fixed by #522
Labels
adapter Related to validation adapters

Comments

@valterkraemer
Copy link

  • Before posting an issue, read the FAQ and search the previous issues.

Description
effect adapter errors when using Schema directly from effect instead of @effect/schema. This is the recommended way of doing it since Effect 3.10

Argument of type 'Struct<{ name: typeof String$; }>' is not assignable to parameter of type 'AnySchema'.
  Property '[TypeId]' is missing in type 'Struct<{ name: typeof String$; }>' but required in type 'Schema<any, any, never>'.
Screenshot 2024-10-31 at 17 28 00

If applicable, a MRE
https://www.sveltelab.dev/8utko5i2yydzzjo

@valterkraemer valterkraemer added the bug Something isn't working label Oct 31, 2024
@ciscoheat
Copy link
Owner

Those eternal updates... I'll put it up for the next release.

@ciscoheat ciscoheat added next Will be implemented in the next release adapter Related to validation adapters and removed bug Something isn't working labels Nov 1, 2024
@valterkraemer
Copy link
Author

Those eternal updates... I'll put it up for the next release.

Great! Appreciate it!

@ciscoheat
Copy link
Owner

There are some breaking types in the 3.10 update that I cannot figure out. @szethh can you take a look at an update for the adapter, perhaps?

@ciscoheat ciscoheat removed the next Will be implemented in the next release label Nov 15, 2024
@szethh
Copy link
Contributor

szethh commented Nov 15, 2024

sure, i knew this was coming ahah 😅

right after we merged the adapter pr they combined Schema into the greater effect namespace.

will do this over the next week

@ciscoheat
Copy link
Owner

Thanks, I'll make a Superforms release today, just so you'll be using the latest version. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter Related to validation adapters
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants