Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for refreshing auth token while collecting data via honk #58

Open
2 tasks
lautriv opened this issue Oct 9, 2023 · 1 comment
Open
2 tasks

Allow for refreshing auth token while collecting data via honk #58

lautriv opened this issue Oct 9, 2023 · 1 comment

Comments

@lautriv
Copy link

lautriv commented Oct 9, 2023

馃挕 Summary

It would be wonderful if the team could refactor the collection functions to allow for refreshing tokens during goosey honk.

Motivation and context

When performing a collection via honk on a large tenant it is common for the authentication token to expire prior to the completion of collection. E.g.

2023-10-06 19:32:36,067 - azure_ad_datadumper - ERROR - Error with authentication token: Lifetime validation failed, the token is expired. (azure_ad_datadumper.py:399)
2023-10-06 19:32:36,067 - azure_ad_datadumper - ERROR - Please re-auth. (azure_ad_datadumper.py:400)

While a user could collect items individually by modifying .conf and repeatedly running honk, I don't think that is sustainable in the long term.

Implementation notes

I would expect that honk (and the underlying modules) will need to have functionality added to be able to:

  • Detect when a token has expired
  • Pause collection
  • Re-prompt the user for authentication
  • Resume collection once a new token has been received

Alternatively, we might be able to use refresh tokens assuming those are available for the application authentication flows.

Acceptance criteria

How do we know when this work is done?

  • honk is able to detect when an authentication token has expired
  • honk will request a new authentication token and resume collection
@AuthMon
Copy link

AuthMon commented Oct 24, 2023

This would be a great feature for use in larger tenants where execution can take several hours.
The current build looks for 429 response from graph API and terminates after an hour of execution with a message asking for re-auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants