Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify a platform in the Molecule test configuration #113

Open
2 tasks
mcdonnnj opened this issue Aug 1, 2022 · 3 comments
Open
2 tasks

Specify a platform in the Molecule test configuration #113

mcdonnnj opened this issue Aug 1, 2022 · 3 comments
Assignees
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@mcdonnnj
Copy link
Member

mcdonnnj commented Aug 1, 2022

馃挕 Summary

We should consider specifying a platform in our Molecule configurations.

Motivation and context

This would both allow us to test multiple platforms in a given configuration (amd64 and aarch64/arm64 for example) as well as ensure that the desired platform is tested regardless of the underlying hardware. The former would allow us to ensure our roles are compatible with AWS Graviton2-based instances for our own purposes. The latter would help ensure that with the rollout of Apple silicon (ARM) that the amd64 platform is still tested explicitly.

Implementation notes

Support for this was added in ansible-community/molecule-docker#122 which was included in molecule[docker] v2.0.0.

Acceptance criteria

  • Molecule testing is enabled for non-amd64 platforms.
  • Molecule testing works even when run on non-amd64 hardware.
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Aug 1, 2022
@mcdonnnj mcdonnnj added this to To do in Skeleton Maintenance via automation Aug 1, 2022
@jsf9k jsf9k self-assigned this Sep 30, 2022
@jsf9k jsf9k moved this from To do to In progress in Skeleton Maintenance Sep 30, 2022
@jsf9k
Copy link
Member

jsf9k commented Sep 30, 2022

@mcdonnnj - do you think that the arm64v8 platform should be handled as a separate scenario, or should we double the number of platforms served by the default scenario?

@mcdonnnj
Copy link
Member Author

@jsf9k I think increasing the number of platforms served by the default scenario makes the most sense for this specific change. However, I'm not opposed to treating different underlying architectures as different scenarios if you think that would be a better implementation.

@jsf9k
Copy link
Member

jsf9k commented Sep 30, 2022

@jsf9k I think increasing the number of platforms served by the default scenario makes the most sense for this specific change. However, I'm not opposed to treating different underlying architectures as different scenarios if you think that would be a better implementation.

I will try to include them in the default scenario, but there may not be sufficient disk space on the GH Actions runners for that.

cisagovbot pushed a commit that referenced this issue Nov 8, 2022
Update Go installation in the `build.yml` workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Status: In Progress
Status: In progress
Skeleton Maintenance
  
In progress
Development

No branches or pull requests

2 participants