Skip to content

Commit

Permalink
Merge pull request #248 from cisagov/improvement/sslyze3
Browse files Browse the repository at this point in the history
Add support for sslyze 3  (superset of PR #214)
  • Loading branch information
felddy committed Oct 16, 2023
2 parents b8014be + 2343690 commit 4f9b94f
Show file tree
Hide file tree
Showing 5 changed files with 168 additions and 174 deletions.
58 changes: 11 additions & 47 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ jobs:
- id: setup-python
uses: actions/setup-python@v4
with:
# A lower version is used because of a dependency issue in Python
# versions 3.8-3.11
python-version: "3.7"
python-version: "3.10"
# We need the Go version and Go cache location for the actions/cache step,
# so the Go installation must happen before that.
- id: setup-go
Expand Down Expand Up @@ -115,24 +113,12 @@ jobs:
matrix:
os:
- ubuntu-latest
# The versions of nassl pinned by our sslyze version constraint only
# have bdists available for Python 3.6 and 3.7, so we can only support
# those versions of Python. The error seen when trying to install on
# Python 3.8+ is:
# ERROR: Cannot install pshtt because these package versions have
# conflicting dependencies.
# The conflict is caused by:
# sslyze 2.1.4 depends on nassl<2.3.0 and >=2.2.0
# sslyze 2.1.3 depends on nassl<2.3.0 and >=2.2.0
python-version:
- "3.7"
# - "3.8"
# - "3.9"
# - "3.10"
- "3.8"
- "3.9"
- "3.10"
# - "3.11"
include:
- os: ubuntu-20.04
python-version: "3.6"
steps:
- uses: actions/checkout@v3
- id: setup-python
Expand Down Expand Up @@ -182,9 +168,7 @@ jobs:
- id: setup-python
uses: actions/setup-python@v4
with:
# A lower version is used because of a dependency issue in Python
# versions 3.8-3.11
python-version: "3.7"
python-version: "3.10"
- uses: actions/cache@v3
env:
BASE_CACHE_KEY: "${{ github.job }}-${{ runner.os }}-\
Expand Down Expand Up @@ -224,20 +208,10 @@ jobs:
- ubuntu-latest
python-version:
- "3.7"
# Disabled due to an unresolvable dependency issue between sslyze and
# nassl:
# ERROR: Cannot install pshtt because these package versions have
# conflicting dependencies.
# The conflict is caused by:
# sslyze 2.1.4 depends on nassl<2.3.0 and >=2.2.0
# sslyze 2.1.3 depends on nassl<2.3.0 and >=2.2.0
# - "3.8"
# - "3.9"
# - "3.10"
- "3.8"
- "3.9"
- "3.10"
# - "3.11"
include:
- os: ubuntu-20.04
python-version: "3.6"
steps:
- uses: actions/checkout@v3
- id: setup-python
Expand Down Expand Up @@ -284,20 +258,10 @@ jobs:
- ubuntu-latest
python-version:
- "3.7"
# Disabled due to an unresolvable dependency issue between sslyze and
# nassl:
# ERROR: Cannot install pshtt because these package versions have
# conflicting dependencies.
# The conflict is caused by:
# sslyze 2.1.4 depends on nassl<2.3.0 and >=2.2.0
# sslyze 2.1.3 depends on nassl<2.3.0 and >=2.2.0
# - "3.8"
# - "3.9"
# - "3.10"
- "3.8"
- "3.9"
- "3.10"
# - "3.11"
include:
- os: ubuntu-20.04
python-version: "3.6"
steps:
- uses: actions/checkout@v3
- id: setup-python
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ organizations](https://github.com/cisagov/pshtt/graphs/contributors).

## Getting started ##

`pshtt` requires **Python 3.6 or 3.7**. Python 2 is not supported.

`pshtt` can be installed as a module, or run directly from the
repository.

Expand Down
14 changes: 5 additions & 9 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,18 +75,14 @@ def get_version(version_file):
# that you indicate whether you support Python 2, Python 3 or both.
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
# "Programming Language :: Python :: 3.8",
# "Programming Language :: Python :: 3.9",
# "Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
# "Programming Language :: Python :: 3.11",
"Programming Language :: Python :: Implementation :: CPython",
],
# The versions of nassl pinned by our sslyze version constraint only have
# bdists available for cp36 and cp37 on PyPI so we can only support Python
# 3.6 and 3.7 at this time.
python_requires=">=3.6, <3.8",
python_requires=">=3.7",
# What does your project relate to?
keywords="https best practices",
packages=find_packages(where="src"),
Expand All @@ -103,7 +99,7 @@ def get_version(version_file):
"requests>=2.18.4",
# This is necessary to support the python_requires kwarg
"setuptools >= 24.2.0",
"sslyze>=2.1.3,<3.0.0",
"sslyze>=3.0.0,<5.0.0",
"wget>=3.2",
],
extras_require={
Expand Down
2 changes: 1 addition & 1 deletion src/pshtt/_version.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
"""This file defines the version of this module."""
__version__ = "0.6.10"
__version__ = "0.7.0"

0 comments on commit 4f9b94f

Please sign in to comment.