Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List markup in /admin is incorrect #2232

Open
rachidatecs opened this issue May 29, 2024 · 1 comment · May be fixed by #3290
Open

List markup in /admin is incorrect #2232

rachidatecs opened this issue May 29, 2024 · 1 comment · May be fixed by #3290
Assignees
@rachidatecs
Labels
bug Something that isn't working as intended dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow pulled in pulled into a sprint after sprint planning refactor

Comments

@rachidatecs
Copy link
Contributor

rachidatecs commented May 29, 2024 •
edited
Loading

Current Behavior

1- List markup for other websites is currently anchors with empty divs used for spacing:

Screenshot 2024-05-29 at 11 43 40 AM

2- List markup for alternative domains is currently anchors with separating commas:

Screenshot 2024-05-29 at 11 42 04 AM

Expected Behavior

1- Markup should be an unordered list with CSS on li to adjust spacing
2- Markup should be an unordered list with CSS on ul/li to display list items inline with the comma separators as pseudo class CSS content
3- If the results returned are a single item, the markup should use a semantic <p> tag - or no tags. If more than one item, the above ACs apply.

Steps to Reproduce

  1. Inspect items above in dev tools

Environment

No response

Additional Context

No response

Issue Links

No response
@rachidatecs rachidatecs added the bug Something that isn't working as intended label May 29, 2024
@vickyszuchin vickyszuchin added the dev issue is for the dev team label May 29, 2024
@h-m-f-t h-m-f-t changed the title List markup in DJA is incorrect List markup in /admin is incorrect Jun 3, 2024
@PaulKuykendall PaulKuykendall moved this from 👶 New to 🍦 Backlog in .gov Product Board Jun 3, 2024
@PaulKuykendall PaulKuykendall moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Jun 3, 2024
@katypies katypies added the Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow label Aug 2, 2024
@PaulKuykendall
Copy link

@rachidatecs - is this important? sounds like a quickfix, true?

@rachidatecs rachidatecs self-assigned this Jan 2, 2025
@rachidatecs rachidatecs linked a pull request Jan 3, 2025 that will close this issue
Open
32 tasks
@rachidatecs rachidatecs added the pulled in pulled into a sprint after sprint planning label Jan 3, 2025
@abroddrick abroddrick moved this from 🎯 Ready to 👀 In review in .gov Product Board Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rachidatecs rachidatecs

Labels
bug Something that isn't working as intended dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow pulled in pulled into a sprint after sprint planning refactor
Projects
.gov Product Board
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2232: Accessible markup and unit test coverage for admin lists cisagov/manage.get.gov
4 participants
@katypies @PaulKuykendall @rachidatecs @vickyszuchin