Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten PR checklist template #2140

Open
4 tasks
vickyszuchin opened this issue May 6, 2024 · 7 comments
Open
4 tasks

Shorten PR checklist template #2140

vickyszuchin opened this issue May 6, 2024 · 7 comments
Labels

Comments

@vickyszuchin
Copy link

vickyszuchin commented May 6, 2024

Issue description

Shorten PR checklist template. Review checklist and identify elements for removal to streamline the template for efficiency. However, we want

Acceptance criteria

  • review checklist and identify elements for removal to streamline the template for efficiency
  • discuss proposed updates to the checklist template with the team
  • update checklist template
  • Make a PR review section of our readmes that talks about our best practices and be sure to include the main steps of the current checklist (see additional context)

Additional context

When adding the PR review section to our readmes, this is to preserve our current best checklist for future developers that may onboard at another time. That said, you don't need repeat all the steps that duplicate for original developer, design reviewer and design reviewer
Please wait until additional engineers/devs have onboarded, approximately July 2024.

Links to other issues

@vickyszuchin
Copy link
Author

Per action item from eng huddle.

@PaulKuykendall
Copy link

weather-gov/weather.gov#279 (comment) has an interesting process.

@PaulKuykendall
Copy link

@abroddrick - please wordsmith this and move to Ready at your discretion.

@abroddrick
Copy link
Contributor

Already did!

@rileyorr
Copy link

Hey all! Just dropping by to mention that I created a ticket to synthesize the accessibility survey findings that may influence some updates made to the PR checklist template as part of this ticket.

cc @gabydisarli @Katherine-Osos

@gabydisarli
Copy link
Contributor

During our design sync on May 21st, we discussed introducing a new process for how we'll track when issues have bypassed the design phase. We decided that we should add an item to the PR checklist that has something along the lines of:

check with design to make sure the work to update the figma and content docs is documented (should only apply to issues with the "design-artifact-update" label.

cc: @vickyszuchin

@h-m-f-t
Copy link
Member

h-m-f-t commented May 28, 2024

I raised this higher in the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🍦 Backlog
Development

No branches or pull requests

6 participants