-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten PR checklist template #2140
Comments
Per action item from eng huddle. |
weather-gov/weather.gov#279 (comment) has an interesting process. |
@abroddrick - please wordsmith this and move to Ready at your discretion. |
Already did! |
Hey all! Just dropping by to mention that I created a ticket to synthesize the accessibility survey findings that may influence some updates made to the PR checklist template as part of this ticket. |
During our design sync on May 21st, we discussed introducing a new process for how we'll track when issues have bypassed the design phase. We decided that we should add an item to the PR checklist that has something along the lines of:
cc: @vickyszuchin |
I raised this higher in the backlog. |
Issue description
Shorten PR checklist template. Review checklist and identify elements for removal to streamline the template for efficiency. However, we want
Acceptance criteria
Additional context
When adding the PR review section to our readmes, this is to preserve our current best checklist for future developers that may onboard at another time. That said, you don't need repeat all the steps that duplicate for original developer, design reviewer and design reviewer
Please wait until additional engineers/devs have onboarded, approximately July 2024.
Links to other issues
The text was updated successfully, but these errors were encountered: