Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkify H2-H6 anchors to make sharing URLs more useful #255

Closed
4 tasks done
h-m-f-t opened this issue Feb 27, 2024 · 4 comments · Fixed by #296
Closed
4 tasks done

Linkify H2-H6 anchors to make sharing URLs more useful #255

h-m-f-t opened this issue Feb 27, 2024 · 4 comments · Fixed by #296
Assignees
Labels
carryover Carryover from a previous sprint dev For developers to work on

Comments

@h-m-f-t
Copy link
Member

h-m-f-t commented Feb 27, 2024

Issue description

When helping users, the program team often shares a URL directly to the page and content on the page (e.g., https://get.gov/domains/before/#steps-to-take-before-you-request-your-.gov-domain). We craft the URL manually by going to browser dev tools and grabbing the ID to append to the URL. Users who click the link land directly on the page and at the content we want them to see on the page.

To streamline this and make our content easier to direct-link to, let's make headers linkable.

Acceptance criteria

  • headers' styling should change (on mouseover but without an icon).
  • Headers (2-6) should be linkified, allowing anyone to click a header and have their browser directed to that content
  • Ensure special characters are stripped in this link
  • The above should apply to current headers and future headers

Additional context

  • Cameron doesn't have a strong preference on the styling question
  • We should take care to follow any USWDS guidance on this, particularly around accessibility

Links to other issues

No response

@vickyszuchin vickyszuchin added the dev For developers to work on label Feb 27, 2024
@abroddrick
Copy link
Contributor

@Katherine-Osos does design want to weigh in on AC #1 or is this intended to just be an engineering only determination?

@Katherine-Osos
Copy link
Contributor

I think underlining the heading upon mouseover makes sense. But I don't think a link icon is necessary (as in the GitHub example) @gabydisarli Any opinion on how this should look?

@gabydisarli
Copy link
Contributor

I think underlining the heading upon mouseover makes sense. But I don't think a link icon is necessary (as in the GitHub example) @gabydisarli Any opinion on how this should look?

Agreed! I love the underline on mouseover, but would pass on the always present icon

@vickyszuchin
Copy link

Per guidance, any "In review" tickets from sprint 45 will be moved over to Sprint 46 noon EST on Day 4 (5/28).

@vickyszuchin vickyszuchin added the carryover Carryover from a previous sprint label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carryover Carryover from a previous sprint dev For developers to work on
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

8 participants